Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Navbar toggler icon use mask instead of background-image #39109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 24, 2023

Description

Use mask instead of background-image

Motivation & Context

Reduce bundle size and will ease the color mode theming since the svg has to be written only once.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality) Since it removes a Sass variable.

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Might close something in #37549.

@louismaximepiton louismaximepiton force-pushed the main-lmp-navbar-toggler-icon-proposal branch from a1e8178 to df97151 Compare August 24, 2023 14:51
@louismaximepiton louismaximepiton changed the title CSS: Use mask instead of background-image CSS: Navbar toggler icon use mask instead of background-image Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

1 participant