Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to clearfix #38528

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Adding a link to clearfix #38528

merged 3 commits into from
Jun 1, 2023

Conversation

ThomasLandauer
Copy link
Contributor

Description

Adding a link to clearfix

Motivation & Context

Basically everybody using floats will need a clearfix, and it's not mentioned at all on the floats page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

This PR template doesn't fit for docs-only changes.

@ThomasLandauer
Copy link
Contributor Author

In fact, it would even be better to merge those two pages into one, named "Float & Clearfix", since nobody needs a clearfix without a float.

@mdo mdo merged commit 785043c into twbs:main Jun 1, 2023
@ThomasLandauer ThomasLandauer deleted the patch-1 branch June 1, 2023 06:22
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
* Adding a link to `clearfix`

* Update float.md

* Update float.md

---------

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants