Fix search modal z-index to be on top of all docs showcased components #36627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search modal currently has a
z-index
set to1030
. That makes it under some showcased components in the documentation; especially the ones that stay displayed even if one clicks outside of it.Here are two examples, popover and toast:
In
_variables.scss
we have this list of z-indexes:I chose
2000
as a value here (maybe too extreme) just to be sure that it will always work in the future.Live previews
Thanks @louismaximepiton for this catch