Carousel: Remove redundant reference to interval=false from docs & tests
#36545
Conversation
There was a problem hiding this comment.
From what I've tested the boolean is just interpreted as a number when the interval is set. So data-bs-interval="false" would be 0 (very quick) and data-bs-interval="true" would be 1 (very quick as well). data-bs-interval="false" isn't used anymore to block the autoplay so I agree with this modification and the fact that the boolean support should be removed.
Maybe consider some extra-modifications in this PR:
- Remove
data-bs-interval="false"incarousel.spec.js - Add something in the migration guide to help the users?
|
Thank you @julien-deramond for your suggestions. I've removed the references from the test file. I don't think we need to add any migration notice. Wishing I am correct, during the latest refactoring, I didn't change the functionality and the checks that are being inside. |
| @@ -314,7 +314,7 @@ const carousel = new bootstrap.Carousel('#myCarousel') | |||
| {{< bs-table >}} | |||
| | Name | Type | Default | Description | | |||
| | --- | --- | --- | --- | | |||
| | `interval` | number | `5000` | The amount of time to delay between automatically cycling an item. If `false`, carousel will not automatically cycle. | | |||
There was a problem hiding this comment.
Shouldn't this read:
| `interval` | number | `5000` | The amount of time to delay between automatically cycling an item. If `0`, carousel will not automatically cycle. |There was a problem hiding this comment.
Apparently with 0 the interval is just very short (no interval) so the animation is very quick. There's a cycle when data-bs-ride is set to true or carousel.
There was a problem hiding this comment.
I agree with Julien here. Are you ok with it @XhmikosR ? can I proceed?
XhmikosR
changed the title
interval=false from docsinterval=false from docs & tests
closes #36526