Fix alert border radius #36461
Merged
Fix alert border radius #36461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
approved these changes
May 29, 2022
There was a problem hiding this comment.
Thanks for the PR <3
Sounds good to me. It reflects the behavior that we had before the CSS custom properties for alerts:
Line 10 in b424650
I need to check in the history but _badge.scss and _tooltip.scss could have the same need of modification.
|
Will do the same for badge and tooltip, thanks :) |
mdo
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not using the mixin, which makes it not work properly with
$enable-rounded: false. Also var fallback was 0, but variable is scoped in the class, and no other usages of border radius seem to do this, so removed.