Re-ordering js default objects #36440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
main-lmp-reorder-js-objects
branch
from
b4a6fa6
to
4abf687
Compare
GeoSot
approved these changes
May 31, 2022
|
TBH I'm not sure how much this makes sense especially since it's not enforced. The docs order might be random too. Just thinking out loud here. |
mdo
approved these changes
Jun 2, 2022
mdo
force-pushed
the
main-lmp-reorder-js-objects
branch
from
4abf687
to
4804a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the issues concerning the CSS part, we encountered with @julien-deramond.
This PR is a split of #36398
Tackled by the PR
Re-order for default objects with (633fca4)
Alphabetical reordering of the default objects. If these changes are approved, it might be great to see if other objects could be updated this way. Just as an example :
bootstrap/js/src/dom/event-handler.js
Line 24 in 416f490