-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted Event handler patches #36171
Conversation
5beca29
to
48c952b
Compare
@julien-deramond @louismaximepiton does these changes make sense to you guys? 😷 |
c64c81d
to
6241cd3
Compare
I haven't tested the minor refactoring but the new naming allows a better understanding.
Regarding callable I don't know well this JS file so I don't have an opinion on this. I just like that it avoids having |
I haven't tested too, but the changes seems good and understandable to me. Regarding the |
Thank you, I 'll keep it in mind, for later usage . For now, I didn't find any other place that needs this functionality |
6241cd3
to
6e84bf9
Compare
e84341d
to
f23f22c
Compare
4525209
to
75f8327
Compare
75f8327
to
05ed16b
Compare
Move check of falsie delegated-selector, caused by tooltip.js
2138e95
to
2170b2a
Compare
mostly renaming, to help my eyes, follow the logic and some minor refactoring to separate some logic