Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode support #35857
Add dark mode support #35857
Changes from all commits
5a343c8
eaa0869
d09cc90
3669ff8
17c3670
451e7c3
c95c068
5ee6ce5
65cce21
cd01c4b
bd303d8
ade37c1
71d0264
fd7580a
564c873
f09eb97
61cbd9d
3676c23
12d82b0
b99606b
1ffcbdf
508957c
1b63a98
36e2264
c59f429
adf418a
40dfd22
5031d41
d5b1b85
3917c03
9163b9f
0cffe85
f39e8d4
eba5fc6
afb664a
1c7b5ba
ad17750
b49a4c4
e3e4dba
aaf89f3
bd67392
1dbc505
d855319
3fe9bd3
59c2b32
1e24b69
0e4e0bb
58b9780
3493066
6e8e0b9
fccb28d
15c8d21
13438b7
a84e038
d83988a
cde601e
5746a4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at it yet but I'm afraid that https://deploy-preview-35857--twbs-bootstrap.netlify.app/docs/5.2/customize/sass/#add-to-map won't work anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On dark mode, it is very difficult to distinguish the normal color and the hovered one on the third slide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, let's save for later with more feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create separate file like https://github.com/ColorlibHQ/AdminLTE/tree/v4-dev/src/scss/bootstrap-dark
so can create addon like files https://github.com/MGatner/adminlte4/tree/develop/dist/css/dark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except if you've found a non-working use case, this modification should be reverted (see a153f36).