-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix btn-light
's active state color
#35293
Fix btn-light
's active state color
#35293
Conversation
btn-light
's active state color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
This is not the best way though, since you're making an exception were we try to have a generic behaviour.
I think we need to question the light color itself, since your issue relates more to the color being to close to white (thus lightening it has almost no effect).
Back to this, I'd say either we consider darkening our default light color (which would concern everything using it) or we consider using the I'd recommend going for this, since we also have contrast issues with some of our outline buttons, that would benefit from a less generic way of building buttons variants — meaning probably to drop the very simple loop and declare at least some variants indepently. This is used in Boosted at least, even if we don't need that much specificity. By doing so, we could get closer to what v4 looked like. Not quite sure yet of how the best values to use, but if you want to give it a shot it'd be really appreciated :) |
Thanks, @ffoodd for your observations on this. |
Is this still something you want to iterate on @tpg-gulshan or should we take a crack at it? |
Thinking about this in another way in #36168. |
Fixes #35258Fixes #34123