Remove custom fallbackPlacements
from the dropdown
#32843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32648
Why to remove
fallbackPlacements
option from the dropdown:fallbackPlacements
right now.Why to keep
fallbackPlacements
option in Tooltip/Popover:Because it provides better placements to Tooltip/Popover IMO (Since there is no official special handing for the placement of Tooltip/Popover on the edges, like-
dropstart
anddropend
for dropdowns). Popper's default value forfallbackPlacements
is [oppositePlacement] it means:More in the description of #32437. So its better to have more fallback placements by default for Tooltip/Popover.
And the flip modifier can be added with
fallbackPlacements
by thepopperConfig
option in case the same issue like #32384 is caused with dropdowns as well (Which is rare in case of dropdowns IMO).