Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update font utility classes to new v5 versions #32449

Merged
merged 3 commits into from
Dec 14, 2020
Merged

examples: Update font utility classes to new v5 versions #32449

merged 3 commits into from
Dec 14, 2020

Conversation

alanorth
Copy link
Contributor

@alanorth alanorth commented Dec 12, 2020

The .font-style-* and .font-weight-* utility classes were renamed to .fst-* and .fw-* in Bootstrap v5 but a few references in the examples didn't get updated.

The font utility class was renamed from .font-italic to .fst-italic
but a few references didn't get updated.
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we may need to check every renamed utilities at some point.

@XhmikosR
Copy link
Member

LGTM, we may need to check every renamed utilities at some point.

Could have a quick look soon please? There shouldn't be too many left, hopefully :)

@alanorth
Copy link
Contributor Author

@XhmikosR I found a few more font-weight-light and font-weight-bold in the RTL docs that should be migrated to fw-light etc. Should I add them to this PR?

@XhmikosR
Copy link
Member

XhmikosR commented Dec 13, 2020 via email

These font utility classes were renamed from .font-weight-* to .fw-*
but a few references didn't get updated.
@alanorth alanorth changed the title site: Fix .font-italic to .fst-italic in blog example site: Update font utility classes to new v5 versions in examples Dec 13, 2020
@alanorth
Copy link
Contributor Author

@XhmikosR I've updated the few other references I found in the documentation. Cheers.

@XhmikosR XhmikosR changed the title site: Update font utility classes to new v5 versions in examples examples:: Update font utility classes to new v5 versions Dec 14, 2020
@XhmikosR XhmikosR changed the title examples:: Update font utility classes to new v5 versions examples: Update font utility classes to new v5 versions Dec 14, 2020
@XhmikosR XhmikosR merged commit f2b39d6 into twbs:main Dec 14, 2020
@alanorth alanorth deleted the v5-font-style-examples branch December 14, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants