Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Lorem Ipsum placeholder text with more representative (or at least english language) text #32246

Merged
merged 17 commits into from
Dec 11, 2020

Conversation

patrickhlauke
Copy link
Member

No description provided.

@XhmikosR
Copy link
Member

The backport will be a PITA, but I like the changes from a quick look :)

@patrickhlauke
Copy link
Member Author

The backport will be a PITA, but I like the changes from a quick look :)

yeah i'm "happy" to do the backport myself. and yes, it'll be manual copy/paste job of the content. hard part i find is inventing some semi-meaningful yet meaningless filler content...

@patrickhlauke
Copy link
Member Author

Got some more to tackle, will set to review once I think I got them all...

with apologies for the weird choice for the long passages... went with content from http://katyperryipsum.com/
@patrickhlauke patrickhlauke marked this pull request as ready for review December 4, 2020 11:52
@patrickhlauke patrickhlauke changed the title First (simple) pass at removing some Lorem Ipsum Replace Lorem Ipsum placeholder text with more representative (or at least english language) text Dec 4, 2020
@patrickhlauke patrickhlauke requested review from mdo and XhmikosR December 4, 2020 11:53
@XhmikosR
Copy link
Member

XhmikosR commented Dec 4, 2020

Did you check the newly added files from RTL @patrickhlauke ?

@patrickhlauke
Copy link
Member Author

@XhmikosR urgh, no i had not. ok...will go hunting later today

@patrickhlauke patrickhlauke marked this pull request as draft December 4, 2020 12:11
@patrickhlauke patrickhlauke marked this pull request as ready for review December 5, 2020 21:41
@patrickhlauke
Copy link
Member Author

Did you check the newly added files from RTL @patrickhlauke ?

apart from the cheatsheet which i didn't have when i started, don't think there's anything else to fix for now - can't really help with checking the arabic (?) content, could do with somebody fluent in the language to give it a double-check to see that it's not just complete gibberish (and that it's nothing offensive or whatever)

@patrickhlauke
Copy link
Member Author

Just to draw attention here (as it may be lost in one of the commit messages) that for some of the more extensive chunks of lorem ipsum I instead used sentences from http://katyperryipsum.com/ (with the SFW option turned on) ... I assume that's acceptable.

@patrickhlauke patrickhlauke merged commit 764e529 into main Dec 11, 2020
@patrickhlauke patrickhlauke deleted the kill-lorem branch December 11, 2020 20:05
patrickhlauke added a commit that referenced this pull request Dec 14, 2020
…least english language) text (#32246)

Replaces shorter examples with more sensible/representative/inforrmative text. For longer passages, resorted to using SFW extracts from http://katyperryipsum.com/
XhmikosR pushed a commit that referenced this pull request Dec 15, 2020
…ative (or at least english language) text (#32462)

Backport and expansion (for v4) of #32246 and #32479
@patrickhlauke patrickhlauke mentioned this pull request Jan 19, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants