Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update karma.conf.js #32182

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Update karma.conf.js #32182

merged 2 commits into from
Nov 18, 2020

Conversation

XhmikosR
Copy link
Member

When we are on CI, this statement won't be reached.

ffoodd
ffoodd approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that, thanks!

@XhmikosR XhmikosR marked this pull request as ready for review November 17, 2020 21:25
@XhmikosR XhmikosR requested a review from a team as a code owner November 17, 2020 21:25
@XhmikosR XhmikosR merged commit 2d4f1b2 into main Nov 18, 2020
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch November 18, 2020 11:06
XhmikosR added a commit that referenced this pull request Nov 18, 2020
@XhmikosR
Backport #32178 and #32182
fc3db71 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 18, 2020
@XhmikosR
Backport #32178 and #32182
d1bf856 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 19, 2020
@XhmikosR
Backport #32178 and #32182
5a5cc5e 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 19, 2020
@XhmikosR
Backport #32178 and #32182
623ed0f 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 19, 2020
@XhmikosR
Backport #32178 and #32182
4e4f739 
Handle Chromium to run Karma
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Nov 20, 2020
XhmikosR added a commit that referenced this pull request Nov 20, 2020
@XhmikosR
Backport #32178 and #32182
f5e8c78 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 23, 2020
@XhmikosR
Backport #32178 and #32182
3281cfc 
Handle Chromium to run Karma
XhmikosR added a commit that referenced this pull request Nov 24, 2020
@XhmikosR
Backport #32178 and #32182
7eee78c 
Handle Chromium to run Karma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
backport-to-v4 skip-changelog So that the release drafter action doesn't include it tests v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @ffoodd