Move js/src/index.js one folder up #32001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, it seems it's purely used for building the dist files. In the main branch we have moved the file one folder up. Not sure how to proceed. I guess we could move it one folder up too or just exclude it from the npm package. |
|
@XhmikosR yep it's used just to build our dist files, so move it outside the source folder can be a solution 👍 |
|
@Johann-S Please approve then 😛 |
Johann-S
approved these changes
Oct 31, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #31823, js/src/index.js and js/src/index.js.map seem unused. I have already removed the map file, but I'm not 100% sure if removing the js file can cause issues with bundlers.
@tkrotoff @rohit2sharma95 Any thoughts?
Fixes #31823