-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc v4 backports #31793
Misc v4 backports #31793
Conversation
0783f63
to
116d138
Compare
116d138
to
fc7d5a3
Compare
Updated @XhmikosR, should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd like another approval from @twbs/css-review for the Sass changes :)
Please use comments for |
They are too verbose and not really needed.
…On Sun, Oct 4, 2020, 02:09 Ihor Zenich ***@***.***> wrote:
Please use comments for .text-break from this commit: e501897
<e501897>
for right correct explanation what are they doing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31793 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNMGN3XWA3VWKY2O3G3SI6VLBANCNFSM4R6INRJQ>
.
|
Ok, but please then at least remove current |
Friendly ping @twbs/css-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
th
updates: Inheritfont-weight: bold
that comes from user agent stylesheets. #30781: Reboot's th updates.text-break
changes to dropoverflow-wrap
and useword-wrap
once again (closes Fix text-break in IE and Edge Legacy #31727)