Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure hidePrevented.bs.modal can be prevented #31696

Merged
merged 8 commits into from
Sep 21, 2020
Merged

ensure hidePrevented.bs.modal can be prevented #31696

merged 8 commits into from
Sep 21, 2020

Conversation

joakimriedel
Copy link

@joakimriedel joakimriedel commented Sep 18, 2020 •
edited by XhmikosR
Loading

Fixes #31615

@joakimriedel joakimriedel requested a review from a team as a code owner September 18, 2020 12:50
@joakimriedel joakimriedel mentioned this pull request Sep 18, 2020
Closed
Johann-S
Johann-S requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @joakimriedel 👍

Just a few modifications and it'll be good to go

js/tests/unit/modal.js Show resolved Hide resolved
js/tests/unit/modal.js Show resolved Hide resolved
@joakimriedel
Copy link
Author

Btw @Johann-S I did not commit the dist folder, assumed that is done somehow by CI?

@Johann-S
Copy link
Member

yep we build the dist folder before each release 👌

@XhmikosR XhmikosR changed the title ensure hidePrevented.bs.modal can be prevented ensure hidePrevented.bs.modal can be prevented Sep 21, 2020
@XhmikosR XhmikosR linked an issue Sep 21, 2020 that may be closed by this pull request
Bug in modal.js: defaultPrevented called on jQuery.Event instead of isDefaultPrevented() #31615
Closed
@XhmikosR XhmikosR merged commit b0a0c56 into twbs:v4-dev Sep 21, 2020
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in modal.js: defaultPrevented called on jQuery.Event instead of isDefaultPrevented()
3 participants
@joakimriedel @Johann-S @XhmikosR