Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box-shadow mixin for .btn #30512

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 4, 2020

This pr:

  • fixes css prop box-shadow when $btn-box-shadow: none
  • passes checking for vars in box-shadow mixin

@zalog zalog requested a review from a team as a code owner April 4, 2020 14:13
@zalog zalog changed the title Zalog btn box shadow btn box shadow fix Apr 4, 2020
@zalog zalog changed the title btn box shadow fix .btn box-shadow fix Apr 4, 2020
@MartijnCuppens MartijnCuppens requested a review from ysds April 5, 2020 17:37
@zalog zalog force-pushed the zalog-btn-box-shadow branch 3 times, most recently from a194380 to 5e75e1f Compare April 7, 2020 06:18
Fixes `box-shadow` property being invalid when that var in `none`.
`box-shadow` mixin already checks for property `none`.
@zalog zalog changed the title .btn box-shadow fix Use box-shadow mixin for .btn Apr 11, 2020
@zalog
Copy link
Contributor Author

zalog commented Apr 11, 2020

Just made a rebase here.

cc:// #30480 and #30555

@MartijnCuppens MartijnCuppens merged commit 8cb60bf into twbs:master Apr 11, 2020
@zalog zalog deleted the zalog-btn-box-shadow branch April 11, 2020 11:46
XhmikosR pushed a commit that referenced this pull request Apr 11, 2020
Use `box-shadow` mixin for `.btn`
XhmikosR pushed a commit that referenced this pull request Apr 13, 2020
Use `box-shadow` mixin for `.btn`
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants