-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spinner-grow animation #30504
Merged
Merged
Fix spinner-grow animation #30504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.
Ping @mdo about @MartijnCuppens's comment above 🙂 |
Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
ysds
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked transition: none
works fine.
XhmikosR
pushed a commit
that referenced
this pull request
Apr 8, 2020
* Fix spinner-grow animation Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue. Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR
pushed a commit
that referenced
this pull request
Apr 9, 2020
* Fix spinner-grow animation Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue. Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR
pushed a commit
that referenced
this pull request
Apr 10, 2020
* Fix spinner-grow animation Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue. Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Fix spinner-grow animation Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue. Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Fix spinner-grow animation Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue. Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari seems to be interpreting the old keyframes animation as incomplete. Adding
transform
to the second frame seems to resolve the issue.Fixes #30493.