tabs - accessibility issue when using ul/li semantic #30381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt has role tablist
|
Why does this target v4-dev specifically? Isn't the issue present in master? |
|
I'll take a look on v5 |
|
We generally target the master branch and then backport stuff in v4-dev. Not sure if the patch will apply clean going from master to v4-dev (probably not), so it should be OK for this specific case. Generally we target master and cherry pick or apply manually what's needed for v4-dev. |
|
thanks for this info for other PR I will target the master |
|
FYI related #30382 (for v5) is approved by @patrickhlauke :) |
|
@XhmikosR It's been merged in v5, I guess it can be merged in v4 too :) |
|
Yeah, still waiting for @patrickhlauke approval, because this isn't a cherry pick. |
patrickhlauke
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #30338 add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc