Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary reduce motion when $enable-transition: false #30183

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

ysds
Copy link
Member

@ysds ysds commented Feb 15, 2020

When $enable-transition: false,

@media (prefers-reduced-motion: reduce) {
   transition: none;
}

is unnecessary.

@XhmikosR
Copy link
Member

@ysds don't forget to add the projects in the PRs :)

@XhmikosR
Copy link
Member

If this is supposed to be backported to v4, we need the 4.4.2 project too.

@XhmikosR
Copy link
Member

Any reason why not include this in alpha-1 and 4.4.2 subsequently?

@ysds
Copy link
Member Author

ysds commented Feb 17, 2020

I think this a minor bug. To speed up the release of Alpha1, I targeted this to Alpha2 not to increase our review work, but now the review was completed it is fine to include this in Alpha1.

I forgot to put it in 4.4.2 ^^;

@XhmikosR XhmikosR merged commit 8087272 into master Feb 17, 2020
@XhmikosR XhmikosR deleted the master-ysds-unnecessary-reduce-motion branch February 17, 2020 07:46
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants