-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent grid with default cols from breaking when large pre is present #30049
Conversation
dcfe5d6
to
0540ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks!
Does this apply to v4 @MartijnCuppens? if so please add the label and project in the PRs you approve. |
Did this one get re-introduced? I noticed this behavior on 4.6.1 and saw this section had been changed: bootstrap/scss/mixins/_grid-framework.scss Lines 24 to 27 in af78de3
and didn't see any min-width here: bootstrap/scss/mixins/_grid-framework.scss Lines 8 to 13 in af78de3
|
Closes #25410 (Codepen with bug present in issue)
Tested this in Codepen: https://codepen.io/jensluyten/pen/povxyPe.
The
min-width: 0;
on the.col
actually prevents the col from taking up the entire row space.This was only an issue on the default cols, because specified cols have a fixed
flex-basis
property that prevents this issue from happening.