-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pseudo-class too for disabled check/radio #29740
Conversation
Maybe we could link to #28247 instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be changed in _form-file.scss
203e866
to
5799a14
Compare
Thanks for the link and the review. I have updated the patch to use the suggested workaround for Edge instead to keep only the |
c4258c4
to
d75d5ed
Compare
I am not a fan of such CSS hack 😕. I think the previous change (both |
@ysds I agree with you, besides it seems to come out of nowhere... I have switched to this hack as it has been tested on Edge and implemented in other projects regarding #28247, and because I cannot confirm that using both |
I agree with @ysds here |
I want to include this to 4.4.1 if we can work quickly. |
d75d5ed
to
3b005e4
Compare
I have made changes accordingly, if someone can confirm that it is working on Edge please. |
I created a PR for v4: #29762 |
So no longer need to rush this PR :) |
I checked the following test cases:
|
In order to consider check/radio inputs inside a disabled fieldset, this first use the :disabled pseudo-class. By the way, the URL of the relevant issue on M$ Edge seems broken or needs at least an account to track its progress...
fixes #29739