Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed input-height-sm and input-height-lg calculations #29653

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Fixed input-height-sm and input-height-lg calculations #29653

merged 2 commits into from
Nov 7, 2019

Conversation

SamDuvall
Copy link
Contributor

@SamDuvall SamDuvall commented Nov 7, 2019 •
edited
Loading

I believe that input-height-sm should use input-padding-y-sm and NOT input-btn-padding-y-sm, because one can override input-padding-y-sm which defaults to input-btn-padding-y-sm.

The same goes for the input-height-lg calculation

@SamDuvall SamDuvall requested a review from a team as a code owner November 7, 2019 18:26
MartijnCuppens
MartijnCuppens approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@XhmikosR XhmikosR merged commit dbeb85c into twbs:master Nov 7, 2019
XhmikosR pushed a commit that referenced this pull request Nov 7, 2019
@SamDuvall @XhmikosR
Fixed input-height-sm and input-height-lg calculations (#29653)
fafe857
@SamDuvall SamDuvall deleted the fix-input-height branch November 7, 2019 18:39
XhmikosR pushed a commit that referenced this pull request Nov 8, 2019
@SamDuvall @XhmikosR
Fixed input-height-sm and input-height-lg calculations (#29653)
62bf6ed
XhmikosR pushed a commit that referenced this pull request Nov 25, 2019
@SamDuvall @XhmikosR
Fixed input-height-sm and input-height-lg calculations (#29653)
eb1e1cf
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@SamDuvall @olsza
Fixed input-height-sm and input-height-lg calculations (twbs#29653)
26560a0
@ffoodd ffoodd mentioned this pull request May 8, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamDuvall @MartijnCuppens @XhmikosR