Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input-height-sm and input-height-lg calculations #29653

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Fixed input-height-sm and input-height-lg calculations #29653

merged 2 commits into from
Nov 7, 2019

Conversation

SamDuvall
Copy link
Contributor

@SamDuvall SamDuvall commented Nov 7, 2019

I believe that input-height-sm should use input-padding-y-sm and NOT input-btn-padding-y-sm, because one can override input-padding-y-sm which defaults to input-btn-padding-y-sm.

The same goes for the input-height-lg calculation

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants