Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sentence #29051

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Updated sentence #29051

merged 1 commit into from
Jul 16, 2019

Conversation

Brianmanden
Copy link
Contributor

Checkboxes and radios use are built to support HTML-based form

=>

Checkboxes and radio buttons support ...

Checkboxes and radios use are built to support HTML-based form

=>

Checkboxes and radio buttons support ...
@XhmikosR XhmikosR requested a review from patrickhlauke July 16, 2019 06:43
@XhmikosR XhmikosR added the docs label Jul 16, 2019
@XhmikosR XhmikosR changed the base branch from v4-dev to master July 16, 2019 06:43
@XhmikosR XhmikosR changed the base branch from master to v4-dev-xmr July 16, 2019 06:44
@XhmikosR
Copy link
Member

Not sure if this applies to master anymore. If so, I'll retarget the PR.

@patrickhlauke
Copy link
Member

Not sure if this applies to master anymore. If so, I'll retarget the PR.

yeah i think @mdo was saying that the whole of forms will be simplified and things like radios/checkboxes will essentially be custom (via CSS) all the way through (e.g. https://deploy-preview-28450--twbs-bootstrap.netlify.com/docs/4.3/forms/checks/)

so yes, only v4 should be needed

@XhmikosR XhmikosR added the v4 label Jul 16, 2019
@XhmikosR XhmikosR merged commit b431bf4 into twbs:v4-dev-xmr Jul 16, 2019
XhmikosR pushed a commit that referenced this pull request Jul 17, 2019
Checkboxes and radios use are built to support HTML-based form

=>

Checkboxes and radio buttons support ...
XhmikosR pushed a commit that referenced this pull request Jul 17, 2019
Checkboxes and radios use are built to support HTML-based form

=>

Checkboxes and radio buttons support ...
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants