Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate bg-variant() mixin #28938

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Conversation

MartijnCuppens
Copy link
Member

Add deprecate mixin for bg-variant() in v4

Closes #28444

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner June 20, 2019 17:54
@MartijnCuppens MartijnCuppens merged commit de163b3 into v4-dev Jun 20, 2019
@MartijnCuppens MartijnCuppens deleted the v4-dev-mc-deprecate-bg-variant branch June 20, 2019 19:30
@mdo mdo mentioned this pull request Jul 22, 2019
sj-i added a commit to sj-i/coreui that referenced this pull request Sep 16, 2020
bg-variant is deprecated at Bootstrap 4.4
twbs/bootstrap#28938

Their usage of bg-variant is modified to ignore the warning.
twbs/bootstrap@e61d609#diff-273d773a27b0f7c4bdba2fdaace98cce

The deprecation part was adopted to coreui, but the ignoring part was not adopted correctly.
coreui@4846c4e#diff-21e435e69ff71979bc2d19b32adf9d5dR5-R15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants