tooltip dispose:removing only own event handler #28896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @david-lallement, Can you create a live demo of the problem via CodePen/JS Bin or Stackblitz ? Because we already use event namespace of jQuery |
|
Hi Johann, |
|
Nice catch @david-lallement 👍 It seems your change broke our unit tests, please can you fix that ? |
|
Hi Johann, |
|
@Johann-S: when you merge this please adapt it for v4 and push it to my v4-dev-xmr branch |
Johann-S
approved these changes
Jun 13, 2019
Johann-S
added a commit
that referenced
this pull request
Jun 13, 2019
|
Now it's fixed thanks @david-lallement 👍 you can see it here: https://codepen.io/Johann-S/pen/zVGmzZ and it'll be available in our next v4 release |
XhmikosR
pushed a commit
that referenced
this pull request
Jun 13, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jun 14, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jun 16, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jun 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tooltip component is in a modal, only the listeners created by the tooltip component should to be removed in the dispose method.
For example, if we subscribe to the hide.bs.modal event of the modal component and call the dispose method of a tooltip component inside, the hide.bs.modal event subscription is lost.
Using of event namespace feature of jquery ensures that only the handler created in _setListeners function is removed in dispose function.