Docs: add accessibility/keyboard callout to popovers, tweak tooltips callout #28851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callout - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
approved these changes
Jun 4, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jun 4, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
pushed a commit
that referenced
this pull request
Jun 5, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
pushed a commit
that referenced
this pull request
Jun 13, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
pushed a commit
that referenced
this pull request
Jun 14, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
pushed a commit
that referenced
this pull request
Jun 16, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
XhmikosR
pushed a commit
that referenced
this pull request
Jun 18, 2019
…callout (#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it would be better to more fundamentally tackle the problems with popovers (as documented here #28446), this at least warns developers (who bother to read the docs) about some of the more blatant abuses/problems...