Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefers-reduced-motion for animated progress bars #28530

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Mar 19, 2019

Check prefers-reduced-motion variable before adding reduced motion media query for animated progress bars

(should have been caught back when #27986 was merged, sorry)

closes #28528

@Johann-S
Copy link
Member

it it possible to do the same for our carousel ?
Because we had a lot of issues about the carousel don't slide on Firefox

@MartijnCuppens MartijnCuppens changed the title Check prefers-reduced-motion variable before adding reduced motion me… Fix prefers-reduced-motion for animated progress bars Mar 20, 2019
@patrickhlauke
Copy link
Member Author

carousel already taken care of the same way in https://github.com/twbs/bootstrap/blob/master/scss/mixins/_transition.scss

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XhmikosR XhmikosR merged commit b4a2beb into master Mar 21, 2019
@XhmikosR XhmikosR deleted the patrickhlauke-progress-animation-reducedmotion branch March 21, 2019 13:59
XhmikosR pushed a commit that referenced this pull request Mar 21, 2019
XhmikosR pushed a commit that referenced this pull request Mar 21, 2019
XhmikosR pushed a commit that referenced this pull request Mar 27, 2019
@XhmikosR XhmikosR added the v4 label Jul 16, 2019
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.progress-bar-animated ignores $enable-prefers-reduced-motion-media-query.
5 participants