Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for MS Edge does not update disabled control's style #28275

Merged
merged 4 commits into from
Mar 17, 2019

Conversation

ysds
Copy link
Member

@ysds ysds commented Feb 15, 2019

Fixes #28247

Before: https://codepen.io/anon/pen/VgEmwV
After: https://codepen.io/anon/pen/PVyGLv

This PR targets the components of the Bootstrap. However, if bootstrap team prefer to fix every situation, it can also add the following CSS to the _reboot.scss.

[disabled] ~ _ {}

@ysds ysds requested a review from a team as a code owner February 15, 2019 02:48
@mdo
Copy link
Member

mdo commented Feb 15, 2019

@MartijnCuppens I haven't tested or reviewed this myself, but likely a candidate for v4 and then bringing back into v5.

@mdo mdo changed the base branch from master to v4-dev February 15, 2019 21:33
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike the attribute selector but if it's the only solution we should do this. We'll revert this again once Edge has switched to Chromium.

@mdo
Copy link
Member

mdo commented Feb 17, 2019

Does the attribute selector cover the psuedo class for all browsers?

@ysds
Copy link
Member Author

ysds commented Feb 19, 2019

The [disabled] and :disabled are theoretically different, so we should test on actually devices. I've tested in:

  • macOS 10.14.2 Chrome 72.0.3626.109
  • macOS 10.14.2 Firefox 65.0.1
  • macOS 10.14.2 Safari 12.0.2 (14606.3.4)
  • macOS 10.14.2 Opera 58.0.3135.65
  • iOS 12.1.4 Chrome 72.0.3626.101
  • iOS 12.1.4 Firefox 15.0 (13894)
  • iOS 12.1.4 Safari
  • iOS 12.1.4 Edge 42.10.3
  • Windows 10 1809 Chrome 72.0.3626.109
  • Windows 10 1809 Firefox 65.0.1
  • Windows 10 1809 IE 11
  • Windows 10 1809 Edge 44.17763.1.0
  • Android 8.1.0 Nexus 5X Chrome 72.0.3626.105
  • Android 8.1.0 Nexus 5X Firefox 65.0.1
  • Android 8.1.0 Nexus 5X Edge 42.0.2.3330

@XhmikosR XhmikosR changed the base branch from v4-dev to master February 19, 2019 11:43
@XhmikosR XhmikosR added the v5 label Feb 19, 2019
@XhmikosR
Copy link
Member

XhmikosR commented Feb 19, 2019

Changed the base branch to master. If it's supposed to be backported in 4.x, mark it or something and we'll cherry pick it when we cut the release.

@XhmikosR XhmikosR merged commit 5e459e9 into twbs:master Mar 17, 2019
XhmikosR pushed a commit that referenced this pull request Mar 18, 2019
XhmikosR pushed a commit that referenced this pull request Mar 21, 2019
XhmikosR pushed a commit that referenced this pull request Mar 27, 2019
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The disabled property value of the custom radio button is not reflected in the display on Microsoft Edge
4 participants