Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate form-control-focus mixin #28262

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Deprecate form-control-focus mixin #28262

merged 2 commits into from
Feb 15, 2019

Conversation

MartijnCuppens
Copy link
Member

@mdo once mentioned to remove this function in v5 because it's only used once, so let's warn people using v4 about it.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner February 14, 2019 17:18
@XhmikosR XhmikosR changed the base branch from v4-dev to master February 15, 2019 07:41
@XhmikosR XhmikosR merged commit 28a7abf into master Feb 15, 2019
@XhmikosR XhmikosR deleted the v4-dev-mc-deprecate-form-control-focus branch February 15, 2019 13:51
XhmikosR pushed a commit that referenced this pull request Mar 1, 2019
@MartijnCuppens @XhmikosR
Deprecate form-control-focus mixin (#28262)
fad6dda
@tmorehouse tmorehouse mentioned this pull request Jun 13, 2019
Merged
18 tasks
@alienlebarge alienlebarge mentioned this pull request Jun 27, 2019
Closed
@XhmikosR XhmikosR added the v5 label Jul 16, 2019
@mdo mdo mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartijnCuppens @mdo @XhmikosR