Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make meaning of tooltip's 'selector' option more clear in Bootstrap 3 #27967

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

shaedrich
Copy link
Contributor

Based on #4215
Backport changes made to docs v4 to v3 (#27573)

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

v3 isn't in active development, not sure if we should bother merging this at all.

@shaedrich
Copy link
Contributor Author

Not wrong, but it is still in use by a huge amount of websites.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

Well, yeah but it won't be reflected in our live website regardless. So it's pretty useless.

@shaedrich
Copy link
Contributor Author

Oh, did I chose the wrong branch? Which one will result in being reflected in the live website?

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

The default branch, which is v4-dev and already has this.

@shaedrich
Copy link
Contributor Author

No, I mean for v3 which is as well on the live website: https://getbootstrap.com/docs/3.4/

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

It won't be live because we won't cut a new release like I said.

@XhmikosR XhmikosR closed this Jan 6, 2019
@shaedrich
Copy link
Contributor Author

shaedrich commented Jan 6, 2019

So we v3 adherents have to stuck with confusing information in your documentation. Sad but it can't be helped. Thanks a lot.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

Well, we have to draw the line somewhere. It can't be supported forever. We only released 3.4.0 due to the security issues, and we need to move forward.

@shaedrich
Copy link
Contributor Author

This was not a code change. But you still have the docs live. This was why I changed this,

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

We have v1.0.0 docs live too.

@XhmikosR XhmikosR reopened this Jan 6, 2019
@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

Anyway, I'm gonna merge it but I doubt it'll be live.

@XhmikosR XhmikosR merged commit 9206e46 into twbs:master Jan 6, 2019
@shaedrich
Copy link
Contributor Author

Thank you, @XhmikosR. And sorry if I was disrespectful at any point of our conversation.

@shaedrich shaedrich deleted the patch-1 branch January 6, 2019 16:06
@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2019

All good, it's just that we need to stop bothering with the old releases at some point. I will deploy this one last time and hopefully we won't ever need to bother with 3.x.

@shaedrich
Copy link
Contributor Author

shaedrich commented Jan 6, 2019

Okay, cool. Thanks a lot. This was the thing which was bugging me every time I read this section of the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants