Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems. #26785

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Update gems. #26785

merged 1 commit into from
Jul 6, 2018

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jul 1, 2018

No description provided.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 1, 2018

I'm thinking, we could get rid of the redirect layout. It's only supposed to be seen when JavaScript is disabled.

Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the best in Ruby and you know our docs better than me 😄

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 2, 2018

@mdo: what do you think about removing the redirect layout?

@mdo
Copy link
Member

mdo commented Jul 3, 2018

@XhmikosR If it's unused, remove it. Otherwise, probably fine to leave.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 3, 2018

@mdo: it's basically unused for normal visitors, i.e. with JS enabled.

@XhmikosR XhmikosR merged commit 907f9a7 into v4-dev Jul 6, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-gems branch July 6, 2018 09:19
@mdo mdo mentioned this pull request Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants