Input group - fix margins #26710
Closed
Input group - fix margins #26710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
approved these changes
Jun 19, 2018
andresgalante
force-pushed
the
input_group_fix
branch
from
ed6e4a5 to
3e45a77
Compare
|
@vchebotarev I've patch your PR to add an example of an add on between 2 inputs on the docs. |
andresgalante
force-pushed
the
input_group_fix
branch
from
3e45a77 to
c87c925
Compare
|
This change will cause a problem when there is validation feedback. @andresgalante Please check with the test cases in #25352 |
|
Please see also #25120 |
andresgalante
suggested changes
Jun 19, 2018
There was a problem hiding this comment.
Thanks @ysds I'll change my approval for this PR, sorry @vchebotarev It will cause problems for feedback validation described here #25352 and #25120
Thanks again @ysds for keeping an eye on it
|
Thanks, but we'll pass on this for now as it starts to take us in an even crazier direction with input group support for multiple components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
With the help of input-group i want to make something like this (perfect variant already fixed)
But there is a problem with double borders
So i've fixed it, and now it looks like this - without double margins