Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid bower.json (#24584) #24590

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Remove invalid bower.json (#24584) #24590

merged 1 commit into from
Oct 29, 2017

Conversation

iamam34
Copy link
Contributor

@iamam34 iamam34 commented Oct 29, 2017

Fixes #24584 ("Could you please remove bower.json making it possible for those of us who haven't had time to switch away from Bower to still include Bootstrap (manually) in our projects").

The earlier PR to remove bower support is #23568.

I'm motivated to contribute as part of Hacktoberfest.

@mdo
Copy link
Member

mdo commented Oct 29, 2017

I'm motivated to contribute as part of Hacktoberfest.

Awesome! :D


I think there was an assumption previously that this wouldn't cause errors for folks, and would instead provide an answer when folks go looking for the file. Hearing it's causing issues definitely means this is totally safe to merge for me.

@mdo mdo merged commit 186c22f into twbs:v4-dev Oct 29, 2017
@mdo mdo mentioned this pull request Oct 29, 2017
@myplaneticket
Copy link

How does one download BS4 using bower?

I tried : "bootstrap": "git://github.com/twbs/bootstrap.git#v4.0.0-beta.2" but got EMAILFORMED error as bower install. My json is valid.

@JamesVanWaza
Copy link

@myorangeca

Bower is no longer supported. Use Either Webpack or NPM
See https://getbootstrap.com/docs/4.0/migration/ Under Beta 2 Changes.

@myplaneticket
Copy link

@jgacuca567 thanks, I have been following all the changes since Alpha.3 :) I am well aware bower support was dropped in beta.2.

That wasn't my question. Bower should still allow you to download BS4 files manually using my above method, but its throwing me an error.

@wolfy1339
Copy link
Contributor

wolfy1339 commented Oct 29, 2017

git+https://github.com/twbs/bootstrap should work

@myplaneticket
Copy link

myplaneticket commented Oct 29, 2017

@wolfy1339

Still same error...

"bootstrap": "git+https://github.com/twbs/bootstrap#v4.0.0-beta.2",

image

@twbs twbs locked and limited conversation to collaborators Oct 30, 2017
@mdo
Copy link
Member

mdo commented Oct 30, 2017

There's no more Bower support. Use npm or Yarn, please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants