Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify social.html. #24483

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Simplify social.html. #24483

merged 1 commit into from
Oct 22, 2017

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 20, 2017

This also fixes the wrong usage of site.description instead of page.description in meta description.

From https://shopify.github.io/liquid/filters/default/:

default - returns the given variable unless it is null or the empty string, when it will return the given value, e.g. {{ undefined_variable | default: "Default value" }} #=> "Default value"

This also fixes the wrong usage of `site.description` instead of `page.description` in meta description.
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-simplify-social-html branch from dd613d3 to 4ce7db2 Compare October 22, 2017 16:10
@XhmikosR XhmikosR merged commit 3b75ebf into v4-dev Oct 22, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-simplify-social-html branch October 22, 2017 16:20
@mdo mdo mentioned this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants