Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Chrome box sizing inheritance bug (#22872) #23025

Closed
wants to merge 2 commits into from
Closed

Fixed Chrome box sizing inheritance bug (#22872) #23025

wants to merge 2 commits into from

Conversation

prateekgoel
Copy link
Contributor

@prateekgoel prateekgoel commented Jul 9, 2017

I have changed:

*,
*::before,
*::after {
  box-sizing: inherit; }

to

*,
*::before,
*::after {
  box-sizing: border-box; }

Fixes #22872.

@wolfy1339
Copy link
Contributor

Please remove dist files

@prateekgoel
Copy link
Contributor Author

prateekgoel commented Jul 9, 2017

@wolfy1339 , Should i not compile and make changes to dist files?

@wolfy1339
Copy link
Contributor

They only want changes to the SCSS files only, not the dist files. So no compiling the source

@prateekgoel
Copy link
Contributor Author

Ok thanks. I'll remove those.

@mdo
Copy link
Member

mdo commented Jul 10, 2017

Cool, I'll take a look after the first beta. Thanks!

@prateekgoel
Copy link
Contributor Author

Thanks @mdo
I feel this is a very basic change. Can we have this included at this moment?

@mdo
Copy link
Member

mdo commented Jul 16, 2017

I feel this is a very basic change. Can we have this included at this moment?

Nope, not yet. This PR hasn't been reviewed, hasn't been tested, isn't an urgent bug (only affects one HTML element), misses the follow-up step of removing the now duplicate box-sizing from the html selector above, and includes compiled CSS files.

@prateekgoel
Copy link
Contributor Author

prateekgoel commented Jul 17, 2017

Ok Thanks @mdo.
By the way, I already removed the compiled files from dist directory as per comment by wolfy1339.

Regarding duplicate box-sizing from the html selector above:
I think as we already have box-sizing:border-box; in wildcard selector *, we can safely remove box-sizing:border-box; from html.

I would like to work for the above solution. Let me know if you are good with above solution.

@mdo
Copy link
Member

mdo commented Jul 17, 2017

You still have compiled CSS in your diff.

@prateekgoel
Copy link
Contributor Author

prateekgoel commented Jul 17, 2017

Ok, so you mean I should only change the particular scss file. I'll do this and update.
Thanks.

@prateekgoel
Copy link
Contributor Author

I have done the required change and submitted a new PR #23118
You can close this one.
@mdo - Please review and share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants