Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .font-weight-light class, add !important to the classes #22963

Merged
merged 3 commits into from
Aug 11, 2017
Merged

Add .font-weight-light class, add !important to the classes #22963

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c4497
Add .font-weight-light class, add !important to the classes
mdo Jul 2, 2017
218088d
Add $font-weight-light var
mdo Jul 2, 2017
ccbe940
300, not light
mdo Jul 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ $font-size-lg: 1.25rem !default;
$font-size-sm: .875rem !default;
$font-size-xs: .75rem !default;

$font-weight-light: light !default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such thing as font-weight: light - there's lighter, but it's relative and I'm not sure it's what you wanted to achieve here. Alternatively it could be 300, but it would need to be tested with the font stack if it reliably supports this weight (or at least does a fallback to other weight that 'looks light')

$font-weight-normal: normal !default;
$font-weight-bold: bold !default;

Expand Down
7 changes: 4 additions & 3 deletions scss/utilities/_text.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@

// Weight and italics

.font-weight-normal { font-weight: $font-weight-normal; }
.font-weight-bold { font-weight: $font-weight-bold; }
.font-italic { font-style: italic; }
.font-weight-light { font-weight: $font-weight-light !important; }
.font-weight-normal { font-weight: $font-weight-normal !important; }
.font-weight-bold { font-weight: $font-weight-bold !important; }
.font-italic { font-style: italic !important; }

// Contextual colors

Expand Down