Added alias for euro -> eur #14869
Merged
Added alias for euro -> eur #14869
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to backward compatibility, we can't actually rename it. We could add an alias though. |
|
Currently there are no aliases as far as I know.. Should I just update the .less file? |
lipis
changed the title
|
Squashed and just added another entry.. let me know if that's fine or we can just forget about this :) |
|
@lipis: you need to do fetch and rebase for Travis to pass. This seems a right addition and in fact |
| @@ -34,6 +34,7 @@ | |||
| .glyphicon-asterisk { &:before { content: "\2a"; } } | |||
| .glyphicon-plus { &:before { content: "\2b"; } } | |||
| .glyphicon-euro { &:before { content: "\20ac"; } } | |||
| .glyphicon-eur { &:before { content: "\20ac"; } } | |||
There was a problem hiding this comment.
Why not just do it like this?
.glyphicon-euro,
.glyphicon-eur { &:before { content: "\20ac"; } }There was a problem hiding this comment.
You're right.. fixed..
|
@XhmikosR Travis is green now :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14867
I didn't update the minified/map files but could do that if necessary.. or not update some of the files that I updated already :)