Use container instead of parent for tooltip/popover auto-placement calcs #14623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If only this had a unit test hint hint 😄 Anyways, I was thinking that using the |
|
Fair point regarding the lack of unit test. |
|
That's why I didn't open a PR with the change myself yet. |
|
Okay, I added a unit test. |
|
Great, LGTM. |
Fixes #14561. Big thanks to @wickstargazer. [skip validator]
cvrebert
added a commit
that referenced
this pull request
Sep 25, 2014
Use container instead of parent for tooltip/popover auto-placement calcs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14561.
CC: @fat for review