Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fire hidden event when tooltip is destroyed #14571

Merged
merged 1 commit into from
Sep 13, 2014

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Sep 8, 2014

Fixes #13031.

@hnrch02 hnrch02 added the js label Sep 8, 2014
@hnrch02 hnrch02 added this to the v3.2.1 milestone Sep 8, 2014
@hnrch02
Copy link
Collaborator Author

hnrch02 commented Sep 13, 2014

Broken example (does not fire hidden.bs.tooltip when it is destroyed): http://jsbin.com/poribo/1/edit
Fixed example (does fire hidden.bs.tooltip when it is destroyed): http://jsbin.com/poribo/2/edit

@cvrebert
Copy link
Collaborator

👍

@hnrch02 hnrch02 force-pushed the properly-hide-tooltip-on-destroy branch from 122c5f2 to 3bb8770 Compare September 13, 2014 00:57
@hnrch02 hnrch02 changed the title Properly hide tooltip when it is destroyed Properly fire hidden event when tooltip is destroyed Sep 13, 2014
@hnrch02 hnrch02 force-pushed the properly-hide-tooltip-on-destroy branch from 3bb8770 to 7676216 Compare September 13, 2014 01:07
hnrch02 added a commit that referenced this pull request Sep 13, 2014
Properly fire hidden event when tooltip is destroyed
@hnrch02 hnrch02 merged commit a3a04bf into master Sep 13, 2014
@hnrch02 hnrch02 deleted the properly-hide-tooltip-on-destroy branch September 13, 2014 01:11
@cvrebert cvrebert mentioned this pull request Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip destroy method never triggers hidden event when using animation
2 participants