Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set git clone depth to 10 for Travis to make it faster #14497

Merged
merged 1 commit into from
Sep 3, 2014
Merged

Set git clone depth to 10 for Travis to make it faster #14497

merged 1 commit into from
Sep 3, 2014

Conversation

BBosman
Copy link
Contributor

@BBosman BBosman commented Sep 1, 2014

Just noticed that on the Apache Cordova project they've set the git clone depth for Travis to 10 as a performance optimization.

Could be an interesting optimization for Bootstrap as well.

Related Cordova commit

@cvrebert cvrebert added the grunt label Sep 1, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Sep 1, 2014
cvrebert added a commit that referenced this pull request Sep 3, 2014
Set git clone depth to 10 for Travis to make it faster
@cvrebert cvrebert merged commit 037ccb4 into twbs:master Sep 3, 2014
@cvrebert cvrebert mentioned this pull request Sep 3, 2014
@XhmikosR
Copy link
Member

XhmikosR commented Oct 7, 2014

This will bite us in the ass if a PR is frequently rebased. But I guess time will tell.

@hnrch02
Copy link
Collaborator

hnrch02 commented Oct 7, 2014

@XhmikosR Unless someone rebases with --committer-date-is-author-date that's not gonna happen.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 7, 2014

I have seen this to fail numerous times. Say you cherry pick a patch and make a new PR.

Anyway, time will tell how frequently will this affect us.

@hnrch02
Copy link
Collaborator

hnrch02 commented Oct 7, 2014

When I cherry-pick the committer date gets set to right now.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2014

@XhmikosR What problem does this cause for rebases exactly? Genuinely curious.
AFAIK, there's nothing in our Travis build that needs the git history beyond the head commit.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 7, 2014

@cvrebert: the issue can happen when force push is used in a branch and the commits exceed the depth before Travis manages to start a build; then it will error out with a commit doesn't exist message.

10 is a nice depth, but I would probably go with a little higher.. Usually our PRs aren't so big, so we probably won't hit the issue at all with a bigger depth.

@BBosman BBosman deleted the clone-depth branch November 17, 2014 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants