Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Remove redundant visually hidden "(current)" from pagination controls #31891

Closed
patrickhlauke opened this issue Oct 14, 2020 · 0 comments · Fixed by #31892
Closed

[Docs] Remove redundant visually hidden "(current)" from pagination controls #31891

patrickhlauke opened this issue Oct 14, 2020 · 0 comments · Fixed by #31892
Labels
accessibility docs v5

Comments

@patrickhlauke
Copy link
Member

https://getbootstrap.com/docs/4.5/components/pagination/
https://v5.getbootstrap.com/docs/5.0/components/pagination/

Remove the <span class="visually-hidden">(current)</span> where the controls already have aria-current

xref #30079 (comment)
@patrickhlauke patrickhlauke mentioned this issue Oct 14, 2020
Merged
patrickhlauke added a commit that referenced this issue Oct 14, 2020
@patrickhlauke
Remove redundant visually hidden "(current)" when aria-current alre…
2c29088 
…ady used

Closes #31891
@patrickhlauke patrickhlauke mentioned this issue Oct 14, 2020
Merged
patrickhlauke added a commit that referenced this issue Oct 14, 2020
@patrickhlauke
Remove redundant visually hidden "(current)" from pagination controls (…
836a4c0 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
XhmikosR pushed a commit that referenced this issue Oct 26, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
e5fdb10 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
XhmikosR pushed a commit that referenced this issue Oct 27, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
6f8a338 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
XhmikosR pushed a commit that referenced this issue Oct 27, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
5f1bc4a 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
@ffoodd ffoodd mentioned this issue Dec 9, 2020
Merged
ffoodd added a commit that referenced this issue Dec 9, 2020
@ffoodd
Drop redundant (current) text
1daf8b9 
USeless since we're using `aria-current` (see #31891).
XhmikosR pushed a commit that referenced this issue Dec 9, 2020
@ffoodd
cheatsheet: Drop redundant (current) text (#32401)
0f12f58 
Useless since we're using `aria-current` (see #31891).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant visually hidden "(current)" from pagination controls twbs/bootstrap
2 participants
@XhmikosR @patrickhlauke