.nav-pills links - wrong nesting in nav.scss

[Kopyov]

In tabs we have correct nesting logic:

.nav-tabs {
    .nav-link.active,
    .nav-item.show .nav-link {
        ...
    }
}

But in .nav-pills it's incorrect:

.nav-pills {
    .nav-link {
        &.active,
        .show > & {
            ...
        }
    }
}

Basically .show > & means .show > .nav-pills .nav-link, but should be .nav-pills .show > .nav-link

[Johann-S]

It seems related to our v4, is that true @Kopyov ?

[Kopyov]

Yes, that is correct - in Beta. Sorry didn't mention it

[XhmikosR]

I think this was changed recently here #22513

[andresgalante]

@Kopyov thanks for reporting it, @XhmikosR is right, it was fixed: https://github.com/twbs/bootstrap/blob/v4-dev/scss/_nav.scss#L80