Nav Pills with open dropdown don't reflect the nav-pills active state… #22513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
May 26, 2017
scss/_nav.scss
Outdated
| color: $nav-pills-active-link-color; | ||
| background-color: $nav-pills-active-link-bg; | ||
| } | ||
| .nav-link[aria-expanded="true"], |
There was a problem hiding this comment.
We don't put aria roles in our selectors. This should likely be removed.
scss/_nav.scss
Outdated
| } | ||
| .nav-link[aria-expanded="true"], | ||
| .nav-link.active, | ||
| .nav-item.show .nav-link { |
There was a problem hiding this comment.
Consider removing the .nav-item from .nav-item.show .nav-link so it's a slightly less specific selector?
pat270
force-pushed
the
nav-pills-dropdown-highlight
branch
from
3a786c4
to
a5ab2b5
Compare
|
I removed the aria role selector and made |
…. The active state should also be reflected when using collapse plugin inside nav-pills.
pat270
force-pushed
the
nav-pills-dropdown-highlight
branch
from
a5ab2b5
to
d71f3c7
Compare
|
This PR will close : #23482 |
mdo
approved these changes
Oct 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The active state should also be reflected when using collapse plugin inside nav-pills.
Latest v4-dev branch doesn't work like the current docs site http://v4-alpha.getbootstrap.com/components/navs/#pills-with-dropdowns. I think it was introduced at 91b6294.
Fixes #23482.