-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support #175
Comments
Would love to hear more about the strategy that goes into this. I'd love to have this part of the library :). |
Actually you could probably just use @ded's awesome rtl tool. https://github.com/ded/R2 |
and if you're not into Node, it has been ported to Ruby as a gem |
And for those who are not into Ruby and Node, would it be a good idea for bootstrap to provide a rtl.less & rtl.css file that could be referenced when needed? |
well, technically those crazy bootstrap folk can vendor R2 and add a simple make task that builds another file. it's as easy as
|
Yeah, that makes sense. I'll try to get a rtl version in for 1.3 |
sadly r2 can't quite handle our css, so this definitely isn't going to be happening for 1.3. Bootstrap is too huge for a manual solution though -- i might try to send some pull requests to r2 at some point and see if i can get it working a bit better for us. |
yeah, the major quirk with R2 at the moment is that it isn't handling nested [@]media queries. @media (min-width:500px) {
p {
color: red
}
} this is a known issue and i've been toying around with a fix for it |
Well, we don't have any media query stuff, but i only really spent like 10 minutes trying to get it working :P i think there was some weird stuff where we had lopsided margins and they weren't getting reversed, so things stacked in odd ways and text wasn't aligned right. i dunno. No big deal |
you need |
oooooooooooooo i'll try that! thanks sir |
My first attempt to do this failed. Mainly because of the combined declarations of padding and margin that specify three values for top, right, bottom but not left, like: |
are you able to see what it output? |
Oh, that's a great notice :-) Never new this before! I will redo the test again after updating the files. Thanks, On Monday, November 21, 2011, Dustin Diaz <
|
Done. Please check it here: |
congrats |
We'll be having media queries in 2.0 - which this still won't work for right? |
Sorry, but I don't understand your question. |
i think that question was for me. in which case, the answer is no, and in the meantime, the only other way that i know of right now, is to use Google's CSS Janus (an even older project I worked on) |
Why won't this work with media queries? Do we close this issue out without supporting it, or is there a way we can do it? |
We have to do it manually was just my point. I think it's still worth doing, so I wouldn't close this out yet. |
To generate, can we remove the @media, use the r2 tools and put them back? Or fix https://github.com/ded/R2 so it works with media query. |
I think for now we're going to leave r2l support be the responsibility of the developer. In the future maybe we'll try to offer some build tools to make this easier - but it's not on the immediate roadmap. |
here's a recently released FULL RTL copy of bootstrap including JS/glyphicons |
Try this tool http://daif.net/script/flipcss.phps |
I think you should reconsider RTL support... There's no convenient RTLed version of bootstrap out there! |
Second this -- it's very important for several projects I'll be working on. |
@BenjaminRH We still waiting for that. ty |
R2 win, simply great: https://github.com/ded/R2 |
Hey there, R2 has become quite a lot powerful including support for skipping certain rules and @media rules support. Still a no go? |
Would be great to have support for right-to-left languages.
The text was updated successfully, but these errors were encountered: