Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navbar form-group in mobile adds extra margin #14557

Closed
fletch3555 opened this issue Sep 7, 2014 · 0 comments · Fixed by #14564
Closed

navbar form-group in mobile adds extra margin #14557

fletch3555 opened this issue Sep 7, 2014 · 0 comments · Fixed by #14564
Labels
confirmed css
Milestone
v3.3.0

Comments

@fletch3555
Copy link

Having a .form-group within a .navbar-form produces a margin-bottom: 5px in the xs view. This is obviously to add spacing between adjacent .form-groups, but the spacing looks weird when there's only one element there.

In this fiddle(http://jsfiddle.net/29ywdc1x/1/), I've added some CSS to zero the margin if the .form-group is the :last-child of it's parent. The fiddle uses the 3.2.0 release from bootstrapcdn, but I discovered it while working locally right after syncing with master.

Let me know what you guys think.
@cvrebert cvrebert added the css label Sep 7, 2014
@mdo mdo modified the milestone: v3.2.1 Sep 8, 2014
@mdo mdo closed this as completed in c6d7d71 Sep 8, 2014
mdo added a commit that referenced this issue Sep 8, 2014
@mdo
Merge pull request #14564 from twbs/fixes_14557
994d0b2 
Fixes #14557: .form-group margin in .navbar-form
@cvrebert cvrebert mentioned this issue Sep 8, 2014
Closed
@mdo mdo mentioned this issue Sep 8, 2014
Merged
Saranya-Raaj pushed a commit to Saranya-Raaj/bootstrap that referenced this issue Oct 9, 2014
@mdo
Fixes twbs#14557: Reset the bottom margin on .form-group:last-child i…
efae4a4 
…n .navbar-form to prevent extra spacing
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#14557: Reset the bottom margin on .form-group:last-…
3d8e7b3 
…child in .navbar-form to prevent extra spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Fixes #14557: .form-group margin in .navbar-form twbs/bootstrap
3 participants
@mdo @cvrebert @fletch3555