Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android <select> workaround JS Bin demo code doesn't quite match the docs #14114

Closed
cvrebert opened this issue Jul 10, 2014 · 4 comments
Closed

Android <select> workaround JS Bin demo code doesn't quite match the docs #14114

cvrebert opened this issue Jul 10, 2014 · 4 comments
Labels
confirmed docs
Milestone
v3.3.0

Comments

@cvrebert
Copy link
Collaborator

Docs: https://github.com/twbs/bootstrap/blob/master/docs/_includes/getting-started/browser-device-support.html#L182
Bin: http://jsbin.com/OyaqoDO/2
Refs #14109.
@cvrebert cvrebert added this to the v3.2.1 milestone Jul 10, 2014
@twbs-lmvtfy
Copy link

Hi @cvrebert!

You appear to have posted a live example (http://jsbin.com/OyaqoDO/2), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:

  • line 110, column 8: Stray start tag script.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@cvrebert
Copy link
Collaborator Author

  • And fix ^^that^^
  • And use Bootstrap "latest" via BootstrapCDN

@mdo mdo closed this as completed in 2000e85 Jul 13, 2014
@mdo
Copy link
Member

mdo commented Jul 13, 2014

http://jsbin.com/OyaqoDO/3

@cvrebert
Copy link
Collaborator Author

To ensure that this is valid HTML: http://jsbin.com/rejajiro/1

cvrebert added a commit that referenced this issue Jul 14, 2014
@cvrebert
fix #14114 mo' betta
5c1746c
krissihall pushed a commit to krissihall/bootstrap that referenced this issue Nov 26, 2014
Merge branch 'master' of https://github.com/krissihall/bootstrap
121507a 
* 'master' of https://github.com/krissihall/bootstrap: (210 commits)
  grunt dist
  Use HTTPS in CDN URLs in _config.yml
  Tabs to spaces
  speed up js tests a bit
  Follow-up to twbs#13907: simplify JS logic for focus shim
  regenerate docs/assets/js/docs.min.js
  popover dismiss-on-next-click example: instead of <button>, use <a> w/ tabindex
  Fix jsbin link
  Another new js bin link
  add docs note about browsers w/ JS disabled; fixes twbs#14134
  fix twbs#14114 mo' betta
  Fix inaccessible buttons.
  typos
  Redundant thanks to bb1286a
  grunt
  Fixes twbs#14074: Make open dropdown nav links in navbar use gradients
  Fixes twbs#14133
  Fixes twbs#14132: add .alert-dismissible to docs examples
  Use bootstrapcdn links
  New Android select example
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
3 participants
@mdo @cvrebert @twbs-lmvtfy