Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .table-condensed to .table-sm (for v4) #10987

Closed
zlatanvasovic opened this issue Oct 8, 2013 · 4 comments
Closed

Rename .table-condensed to .table-sm (for v4) #10987

zlatanvasovic opened this issue Oct 8, 2013 · 4 comments

Comments

@zlatanvasovic
Copy link
Contributor

It will be nice if use .table-sm instead of .table-condensed. .table-sm matches the naming scheme of other components.

@mdo
Copy link
Member

mdo commented Oct 8, 2013

Noted!

@mdo mdo closed this as completed Oct 8, 2013
@mdo
Copy link
Member

mdo commented Oct 8, 2013

To clarify, we have a private v4 list we're tracking. I've added this to the list. <3

@zlatanvasovic
Copy link
Contributor Author

Cool! Ty! :)

2013/10/8 Mark Otto notifications@github.com

To clarify, we have a private v4 list we're tracking. I've added this to
the list. <3


Reply to this email directly or view it on GitHubhttps://github.com//issues/10987#issuecomment-25925466
.

Zlatan Vasović - ZDroid

@kerryj89
Copy link

kerryj89 commented Jun 16, 2020

I wish we reserved xs/sm/md/lg/xl as media query keywords. It was just fine as .table-condensed, imo. Certainly more descriptive and predictive than .table-sm. I had to look it up and my first guess as to its function when migrating from v3 were: "A utility to bundle table display and maybe with some other properties enough for it not to be .d-table and limited to sm viewports".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants