Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.099999999999998px shows up in bootstrap.css #10959

Closed
DavidEGrayson opened this issue Oct 6, 2013 · 5 comments
Closed

16.099999999999998px shows up in bootstrap.css #10959

DavidEGrayson opened this issue Oct 6, 2013 · 5 comments

Comments

@DavidEGrayson
Copy link

Sorry if this was already reported, but I just noticed that in Bootstrap 3.0.0, bootstrap.css has the following line:

font-size: 16.099999999999998px;

That is a waste of network bandwidth and I suspect you really wanted it to be 16.1px.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 6, 2013

Confirmed in master. Affected class is .lead. Corresponds to https://github.com/twbs/bootstrap/blob/master/less/type.less#L14
We should probably ceiling/floor/round the result of the multiplication.

@Merg1255
Copy link

Merg1255 commented Oct 7, 2013

Sure. Good point.

@Thielo
Copy link

Thielo commented Oct 7, 2013

Erm.. Maybe I´m totally wrong now, but... are there 0.x pixel? I allways thought a pixel is empty or its filled..

@mdo
Copy link
Member

mdo commented Oct 7, 2013

@Thielo The point of this issue is that the decimals are a mistake from a LESS calculation function. We'll be using whole pixels after this is addressed.

@DavidEGrayson
Copy link
Author

@Thielo I am not an expert on this stuff, but when you use the Zoom feature of Google Chrome it seems that "px" units in the stylesheet no longer correspond to physical pixels, so it is possible that 16.1px might be a valid thing to choose and it would be different than 16px. You might want to look at the CSS3 specification to see what "px" really means and whether it has to be an integer.

@mdo mdo closed this as completed in 1adbe20 Oct 7, 2013
@mdo mdo mentioned this issue Oct 7, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants