Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the /assets/ folder since it's confusable with /dist/ #10715

Closed
cvrebert opened this issue Sep 19, 2013 · 4 comments · Fixed by #10770
Closed

rename the /assets/ folder since it's confusable with /dist/ #10715

cvrebert opened this issue Sep 19, 2013 · 4 comments · Fixed by #10770
Milestone

Comments

@cvrebert
Copy link
Collaborator

Some other projects use /assets/ for the same/similar purposes that we use /dist/. This can lead to confusion for people new to Bootstrap who don't RTFM.

I propose /doc-assets/ as a potential new name for the folder.

/cc @mdo

@binlabs
Copy link
Contributor

binlabs commented Sep 19, 2013

Agreed. Either that or add a README to the folder noting that the files are specifically for the docs.

I'd be fine with either, but I do think something should be done.

@mdo
Copy link
Member

mdo commented Sep 23, 2013

Word, since that stuff isn't part of the distributed end files, I'm included to rename/move it as part of 3.0.1. I like /docs-assets/ since in the future I'd like to utilize a /docs directory for all the *.html files we have in the root.

@mdo
Copy link
Member

mdo commented Sep 23, 2013

Thinking this through a bit more, it means updating all our docs and examples. We cool with breaking that for people?

@cvrebert
Copy link
Collaborator Author

What would it break exactly?

Or are you referring to people who are hotlinking to our hosted CSS+JS? (Which they really shouldn't be doing anyway.)

mdo added a commit that referenced this issue Sep 24, 2013
move /assets/ to /docs-assets/ ; fixes #10715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants